Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GrSciColl facets #646

Open
MortenHofft opened this issue Dec 9, 2024 · 2 comments
Open

GrSciColl facets #646

MortenHofft opened this issue Dec 9, 2024 · 2 comments
Assignees
Labels
bug GRSciColl Issues related to institutions, collections and staff

Comments

@MortenHofft
Copy link
Member

https://api.gbif.org/v1/grscicoll/institution/search?facet=discipline&discipline=Biological

Facet says

{
"name": "Biological",
"count": 214
},

but count says 404

I expected them to be the same. Am I missing something?

@MortenHofft MortenHofft added bug GRSciColl Issues related to institutions, collections and staff labels Dec 9, 2024
@marcos-lg
Copy link
Contributor

This is because discipline is backed by a vocabulary and the search includes its children but the facets are grouped per concept without taking hierarchies into account.

@MortenHofft I'm not sure how we can make this clearer in the api. Maybe adding a param in the search such as includeChildren=false would help? the default behaviour would still be to include the children.

@MortenHofft
Copy link
Member Author

I had expected both to include children since that is the behaviour we have elsewhere e.g. taxonKeys on occurrenceSearch. Which also includes children. Else animalia wouldn't be billions of results

if we need to get by exact value and not include children we could do (as you say) includeChildren.discipline=false or have a new name like facet=disciplineExact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug GRSciColl Issues related to institutions, collections and staff
Projects
None yet
Development

No branches or pull requests

2 participants