-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concept suggest #140
Comments
For the response format I would like it to be as small as possible so we do not send any unnecessary information over the wire - we want a suggest to be fast.. That means not to include langauge that wont be displayed. And not to include e.g. keys that cannot be used (see #136) |
Thanks Morten! I think that makes sense. I agree that it would be confusing to have in the response terms that seem unrelated to what you are searching in your language. |
This means that this search |
yes - since that is the label the user will see. For all the user knows |
Either only the so
|
Deployed to production the first version that includes the The |
(cherry picked from commit 115e29a)
It is my understanding this has been fixed and implemented so will close the issue. |
It was actually a first version that didn't include the latest suggestion included in this comment #140 (comment) so that's why I left it open. But we might not even need it, it depends on the user experience we get. We can reopen it if needed. |
Ooops. Okay sorry - I'll open it again and see if there is any user feedback during this year. Otherwise I propose we close it again. |
The current suggest isn't useful. It doesn't include parents and it doesn't take language into consideration.
related: #135 #113
imagine these concepts
I now have a site with danish as the language. I open my concept search to select a concept.
What is the labels I see in a dropdown?
Suggestion
I'm not sure what the best experience would be, but here is a suggestion for something we could try.
The full list on the danish site would show (ordering and filtering aside)
How would suggest filtering work. I suggest that we only filter on values the user would actually see.
That means that if I search for
q=mon&locale=da
then I do not get the result forMonkey
. Since the label the user will see isabe
. If I search forq=ab&locale=da
then I will get the result formonkey
If I search for
q=er&locale=da
I will get the result forERT
but not forSerpiente
.If I search for
q=XY1&locale=da
I will get no results.I believe it would be confusing to show the result
Monkey
when the user search formo
on a danish site if the label the user will see isAbe
So essentially one could think of it this way:
Generate the string name for each concept :
danish label | english label | concept name
(same for parents)That would yield
And the filtering for any string (e.g.
er
would be on that list, no other information). similarly if we decide to include descriptions in the search, then it would be on the value the user sees. On a danish site it would never match against english or spanish if there is a danish label/descriptionIf I add multiple locales, then it will search on both labels. E.g.
q=er&locale=da&locale=es
would return bothXY1(mamífERo)
,ASD(sERpiente)
andERT
Another approach
We could also say that you always search in the english labels and concept names in addition to whatever language you specify. That it makes it more powerful that you can search raw values and english. But my gut feelign would be that it is more confusing for most users. And above suggestion alows us to try both versions by providing multiple locales
The text was updated successfully, but these errors were encountered: