Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTT/Keybind Modifier Key Fix #14

Open
im-h opened this issue May 15, 2024 · 3 comments
Open

PTT/Keybind Modifier Key Fix #14

im-h opened this issue May 15, 2024 · 3 comments

Comments

@im-h
Copy link

im-h commented May 15, 2024

When a modifier key (Shift, Ctrl) is pressed, Push-to-Talk does not work (nor does muting or keybinds in general), could this be somehow changed?

@geniiii
Copy link
Owner

geniiii commented Jul 2, 2024

This is likely due to the Win32 hotkey API (see: RegisterHotKey). A workaround in theory would be to reregister the hotkey with all the modifiers set (and I'm not sure if that actually works), but a more proper alternative would be to use RawInput; cancel's reason for not already doing this is to not have Ripcord de facto act as a keylogger. If you're fine with that, I could probably add an option that replaces all the Ripcord hotkeys. It may however significantly raise AV detection rates as we would now not only be hijacking a DLL, but also constantly reading keyboard input...

@im-h
Copy link
Author

im-h commented Jul 3, 2024

This is likely due to the Win32 hotkey API (see: RegisterHotKey). A workaround in theory would be to reregister the hotkey with all the modifiers set (and I'm not sure if that actually works), but a more proper alternative would be to use RawInput; cancel's reason for not already doing this is to not have Ripcord de facto act as a keylogger. If you're fine with that, I could probably add an option that replaces all the Ripcord hotkeys. It may however significantly raise AV detection rates as we would now not only be hijacking a DLL, but also constantly reading keyboard input...

OBS has a similiar issue but i don't know if it's the same, which you can fix by adding the modifier keys, so i'd assume it'll work the same

image

@geniiii
Copy link
Owner

geniiii commented Jul 3, 2024

This is likely due to the Win32 hotkey API (see: RegisterHotKey). A workaround in theory would be to reregister the hotkey with all the modifiers set (and I'm not sure if that actually works), but a more proper alternative would be to use RawInput; cancel's reason for not already doing this is to not have Ripcord de facto act as a keylogger. If you're fine with that, I could probably add an option that replaces all the Ripcord hotkeys. It may however significantly raise AV detection rates as we would now not only be hijacking a DLL, but also constantly reading keyboard input...

OBS has a similiar issue but i don't know if it's the same, which you can fix by adding the modifier keys, so i'd assume it'll work the same

image

OBS uses GetAsyncKeyState to periodically poll for keyboard input, it doesn't actually use the Windows hotkey API. I'll see if registering multiple hotkeys with the same keycode but different modifiers works when I have time. Ripcord doesn't allow it for some reason, which makes me think it might have been deliberate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants