Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about restrictive PacBio License #497

Open
Schmytzi opened this issue Nov 8, 2024 · 1 comment
Open

Warn about restrictive PacBio License #497

Schmytzi opened this issue Nov 8, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Schmytzi
Copy link
Collaborator

Schmytzi commented Nov 8, 2024

Description of feature

The license of PacBio's HiFiCNV and HiPhase prohibits usage with data that was not generated on a PacBio instrument.
Nallo already terminates with an error when HiPhase is used with the ONT preset and we use an older version of HiFiCNV with a more permissive license.
I generally agree with this, as this restriction may not be obvious to the user.
However, I think we should emit a warning when any PacBio tool affected by this license is run, regardless of preset.
Even if Nallo is run with a PacBio preset, there is no guarantee that the input actually is PacBio data. Moreover, it is possible to completely forgo any presets and configure everything manually.

@Schmytzi Schmytzi added the enhancement New feature or request label Nov 8, 2024
@fellen31
Copy link
Collaborator

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants