Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Miss match: geoblacklight seed data / geoblacklight-icons class names #18

Open
ewlarson opened this issue Jun 30, 2016 · 2 comments
Open

Comments

@ewlarson
Copy link
Member

There is a discrepancy between the Solr seed data for Geoblacklight and the institution class names the geoblacklight-icon gem ships.

  • The seed data uses formal naming for document provenance: ex. University of Minnesota
  • Thus, the icon facet helper produces a class name of: geoblacklight-university-of-minnesota
  • The icon gem uses informal naming for icon facet class rendering: ex. geoblacklight-minnesota

Anyway, just pointing this out. It's not a very interesting problem, but perhaps an icons.yml file belongs somewhere to allow a bit of customization?

@mejackreed
Copy link
Member

Seems like a good approach. I guess that icons.yml file would live within GeoBlacklight and would handle the translations between uni's and their formal names?

@krdyke
Copy link
Contributor

krdyke commented Jul 21, 2016

This is more a result of our (my) changing practice with regards to naming. Using formal names results in a bunch of "University of"s without any real benefit to a user. Thus, we changed to less formal names, which is how the rest of GeoBlacklight instances are working anyway. Unfortunately this change occurred after we contributed the seed data, thus the discrepancy. An optional yml to allow custom mapping sounds kinda cool. Another option would be for me to submit seed records corresponding to how we're doing things now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants