Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the mess into a more pythonic way #66

Open
arnaud-morvan opened this issue Sep 7, 2022 · 0 comments
Open

Reorganize the mess into a more pythonic way #66

arnaud-morvan opened this issue Sep 7, 2022 · 0 comments

Comments

@arnaud-morvan
Copy link
Contributor

arnaud-morvan commented Sep 7, 2022

  • Create a folder with python files (maybe create a package)

And we could also:

  • Format code with back

  • Add linter

  • Run tests on CI (maybe using Docker)

  • Install requirements.txt in Dockerfile instead of duplicated list of dependencies

  • Use request everywhere so we can easily write tests using responses

We can also remove .travis.yaml

Not sure we can still user docker folder, it says:

COPY geonetwork.war /var/lib/jetty/webapps
COPY geoserver.war /var/lib/jetty/webapps

But there is nothing else about geonetwork.war or geoserver.war.

Readme says : You should now have a geoserver 2.10 and a geonetwork 3.2 available.

I would prefer a docker-compose.yaml file instead, or instructions to run georchestra/docker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant