Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version updates in module poms are not covered by git add #54

Open
ascheman opened this issue Sep 29, 2022 · 3 comments
Open

Version updates in module poms are not covered by git add #54

ascheman opened this issue Sep 29, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@ascheman
Copy link

I have a multi module project where some of the modules define versions themselves. The versions are updated but the POM files seem not to become part of the final git commit.

I will try to create a test scenario/test case for this as soon as my time permits.

@sparsick sparsick added the bug Something isn't working label Sep 29, 2022
@sparsick
Copy link
Collaborator

Thanks for reporting.

@sparsick
Copy link
Collaborator

sparsick commented Oct 4, 2022

During Cyberland Hacktoberfest event, we could reproduce it with JGit provider (only manually).

Changed files are not part of a commit

@sparsick
Copy link
Collaborator

sparsick commented Oct 4, 2022

Root cause: JGit Provider only add root pom.xml because of line

Native git provider uses it as pattern, but JGit Provider as file name.

sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue Oct 7, 2022
sparsick added a commit to sparsick/dependency-update-maven-plugin that referenced this issue Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants