-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EPIC] Tag all spans during app start with start type info #174
Comments
github-project-automation
bot
moved this to Needs Discussion
in Mobile & Cross Platform SDK
Dec 13, 2024
@markushi do we still need this? Or on the other hand, do we only need this once Insights/product use app start info from spans vs. transactions? |
(@narsaynorath correct me if I'm wrong) Yes, we'd still need this, as it would allow us to filter the span table based on the top App Start Type selection: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For the mobile starfish app start module we want to allow users to be able to filter their spans by warm/cold start. We've decided to propagate a start type property in span data to facilitate this filter.
I propose adding a key called
app_start_type
to the span data field (docs on the data field) which can either have a value ofcold
orwarm
.Tasks
app_start_type
sentry-java#3989app_start_type
sentry-cocoa#4715The linked Relay PR will start filling in
app_start_type
by checking themeasurements
on a transaction to see if there isapp_start_warm
orapp_start_cold
timing. If the value is provided in the data field, then that will take precedence. This is so we can take advantage of the filtering before waiting for new SDK adoption, but will support extraction when moving towards span streaming.It was suggested to use app context but it seems like Android may be missing the start type for certain transactions, e.g. see here. This seems like the most consistent method across Android and iOS at the moment.
The text was updated successfully, but these errors were encountered: