Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PToJSVal be a parent class of IsJSVal? #91

Open
louispan opened this issue Mar 13, 2017 · 2 comments
Open

PToJSVal be a parent class of IsJSVal? #91

louispan opened this issue Mar 13, 2017 · 2 comments
Labels
enhancement

Comments

@louispan
Copy link
Contributor

This way we can have a consistent way to convert to jsval with just pToJSVal, instead of sometime using jsval sometimes using pToJSVal.

Also currently we can't use pToJSVal to convert Maybe JavaScript.Object to a nullable JSVal, because JavaScript.Object is a IsJSVal but not a pToJSVal.
@hamishmack
Copy link
Member

Oops wrong issue

@hamishmack hamishmack reopened this Jul 7, 2017
@johannesgerer
Copy link

Would this solve ghcjs/jsaddle-dom#15 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johannesgerer @hamishmack @louispan