Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught ReferenceError: h$isNode is not defined #9

Closed
spl opened this issue Aug 18, 2015 · 4 comments
Closed

Uncaught ReferenceError: h$isNode is not defined #9

spl opened this issue Aug 18, 2015 · 4 comments

Comments

@spl
Copy link

spl commented Aug 18, 2015

This is due to c5eeeaf and happens if GHCJS_BROWSER is defined. (I'm not really sure why nobody has reported this problem before. It could be something else about the way we're building our app, but I'm not really sure what that would be.)

Should the line be changed as follows?

-  if ( h$isNode ) return;
+  if (typeof h$isNode !== "undefined") return;
@adinapoli
Copy link
Contributor

Ah, I have just stumbled into this myself while trying to fix #14 and as a consequence improve the shape of example/Main.hs.

The fact we are running a patched version of the jquery library surprise me a bit. Isn't there a way to ship the official, minified library?

@spl
Copy link
Author

spl commented Nov 26, 2015

I haven't followed up on this, and I guess it's somewhat telling that nobody else has since I posted it over 3 months ago. We were using a patched ghcjs-jquery but stopped due to my failure at resolving #10. I only needed a few jQuery features, so I wrote the minimal necessary FFI myself.

@adinapoli
Copy link
Contributor

@spl I have opened a PR 2 days ago addressing this as well: #15

Unfortunately nobody reviewed it yet..

@bergey
Copy link
Contributor

bergey commented Dec 22, 2015

closed by #15

@bergey bergey closed this as completed Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants