Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directive doesn't work with last Angular version (1.3.11) #6

Closed
nachoargentina opened this issue Apr 16, 2015 · 4 comments
Closed

Directive doesn't work with last Angular version (1.3.11) #6

nachoargentina opened this issue Apr 16, 2015 · 4 comments

Comments

@nachoargentina
Copy link

Hi!
I was trying this out with AngularJS v1.3.11 and couldn't get the example to work in any way.
After a lot of changes to try to find out what the issue was, I thought of changing to the angular version you are using in the example (1.2.3) and that actually solved the problem!
Here's a Plunker link to show the problem:
http://plnkr.co/edit/oUDsX1tinV73OpRgzMeW?p=preview

Check that in the HTML I'm importing angular version 1.3.11. You will see it doesn't work. If you change the Angular version to 1.2.3, it will start working.
Do you know why the directive is not working on the last angular version? Is there a quick fix to make it work?
Thanks you so much for your time, the directive is top-notch and would love to use it!

@gilbox
Copy link
Owner

gilbox commented Apr 16, 2015

The latest I tried it with is 1.3.0-beta.11... I'll see what I can find out.

@gilbox
Copy link
Owner

gilbox commented Apr 16, 2015

Ok this seems to be related to issue #3 ... add disable-drag="false" to the infinite-slider element.

http://plnkr.co/edit/xBS9uAHe4mOzzCNVkqAU?p=preview

This bug is probably an easy fix. If you'd like to have at it would be greatly appreciated.

@nachoargentina
Copy link
Author

Did I mention you are the greatest? Thank you so much! Adding that property solved the issue.
I will try to fix it in the library and leave a PR for you to check. Thanks again!

@gilbox
Copy link
Owner

gilbox commented Apr 17, 2015

you're welcome :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants