Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customization of _config.yml via jekyll-init script does not work #5

Open
S0AndS0 opened this issue Jun 13, 2020 · 0 comments
Open
Labels
bug Something isn't working

Comments

@S0AndS0
Copy link
Member

S0AndS0 commented Jun 13, 2020

Describe the bug

Lines 181 through 193 of jekyll-init that handle the following options...

--title
--email
--twitter-username
--github-username

... do not seem to edit the _config.yml file as intended.

Furthermore, when --title parameter is used the repository name is overwritten, and the --title parameter is not parsed correctly when spaces are present.

To Reproduce

  • Example one input...
ssh HOST jekyll-init\
  --title 'test title'\
  --email 'test@example.tld'\
  --twitter-username 'S0_And_S0'\
  --github-username 'S0AndS0'\
  test-repo\
  --help
  • Example one output...
# ...
# title
#  Name of repository to internalize or add Jekyll gh-pages branch to
# ...
# --title test
# --email 
# --twitter-username 
# --github-username USER
  • Example one _config.yml (snip)
title: test
email: your-email@example.com
twitter_username: jekyllrb
github_username: USER
  • Example two input...
ssh HOST jekyll-init\
  --title='test title'\
  --email='test@example.tld'\
  --twitter-username='S0_And_S0'\
  --github-username='S0AndS0'\
  test-repo\
  --help
  • Example two output...
# ...
# title
#  Name of repository to internalize or add Jekyll gh-pages branch to
# ...
# --title test
# --email test@example.tld
# --twitter-username S0_And_S0
# --github-username S0AndS0
  • Example two _config.yml (snip)
title: test
email: test@example.tld-email@example.com
twitter_username: jekyllrb
github_username: S0AndS0

In both of the above examples a repository is created under ~/git/title instead of ~/git/test-repo

Expected behavior

In either of the above cases the configuration file should be similar to...

title: test title
email: test@example.tld
twitter_username: S0_And_S0
github_username: S0AndS0

... and the repository should be created under ~/git/test-repo

@S0AndS0 S0AndS0 added the bug Something isn't working label Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant