Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Docker for testing #17

Open
pavelkraleu opened this issue Mar 5, 2024 · 1 comment
Open

Implement Docker for testing #17

pavelkraleu opened this issue Mar 5, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@pavelkraleu
Copy link
Collaborator

pavelkraleu commented Mar 5, 2024

We need to significantly improve testing of this project, having Docker image is the first step

Implementation

  1. Create Dockerfile based on the official Python Image
  2. Update tiktoken to newest version 0.6.0 - Does not require compilation on ARM
  3. Install requirements.txt
  4. Document in Readme how to run project from Docker

Example:

FROM python:3.12

WORKDIR /app

COPY requirements.txt .

RUN pip install --no-cache-dir -r requirements.txt

COPY . .

ENTRYPOINT ["python", "main.py"]
CMD []
@LazaroHurtado
Copy link
Contributor

I like the idea of making improvements around testing but by adding a dockerfile we will only give developers a common dev environment, which would be python:3.12 in your example.

Integration testing can only be done if the user has an API key for the provider and evaluator. I think a good option is to create some GitHub Actions that will load the API keys into the environment through the use of secrets. I believe @gkamradt will have to use his keys and save them as secrets. Here are some resources on what im talking about:

Unit testing on the other hand is something we can totally tackle and should probably prioritize soon before things get too big.

@pavelkraleu pavelkraleu self-assigned this Mar 6, 2024
@pavelkraleu pavelkraleu added this to the Code improvements milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants