From 9d524270ca7bc63840ca8e307bfec79948b13150 Mon Sep 17 00:00:00 2001 From: jdollar Date: Sat, 7 Jan 2017 14:31:59 -0500 Subject: [PATCH] Fixing issues with babel core with a fresh install and test failures Installed a newer version of babel to fix a path undefined error when running babel src. The issue was identified and resolved in the newer versions of babel core. Updated failing tests for batching actions. For the test cases the button click action was not dispatching anything and only setting a timeout. Instead just made it return a null when the actions are called so it will dispatch a null when those actions are called in addition to dispatching. a action when the timeout runs. --- package.json | 2 +- test/batching-test.js | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 8183e339..91592816 100644 --- a/package.json +++ b/package.json @@ -12,7 +12,7 @@ "devDependencies": { "alt-search-docs": "1.0.6", "babel-cli": "6.6.5", - "babel-core": "6.7.4", + "babel-core": "6.21.0", "babel-eslint": "5.0.0", "babel-loader": "6.2.4", "babel-plugin-add-module-exports": "^0.1.2", diff --git a/test/batching-test.js b/test/batching-test.js index 6ef248ff..37485675 100644 --- a/test/batching-test.js +++ b/test/batching-test.js @@ -6,12 +6,13 @@ import sinon from 'sinon' import TestUtils from 'react-addons-test-utils' import ReactDom from 'react-dom' -// TOOD action was called but not dispatched? const Actions = { buttonClick() { setTimeout(() => { this.switchComponent() }, 10) + + return null }, switchComponent() {