Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushd and popd commands still haven't been removed from download scripts on the main branch. #557

Open
dgzct11 opened this issue Aug 7, 2022 · 0 comments
Labels
setup Issue setting up AlphaFold

Comments

@dgzct11
Copy link

dgzct11 commented Aug 7, 2022

Hello,

When I tried to run download_all_data.sh, I kept running into a gzip error where it couldn't find the file. The path and filename seemed right, but when digging through the issues and scripts, I found that download_mgnify.sh, download_small_bfd.sh, download_uniprot.sh, and download_uniref90.sh on the main branch still had the extra pushd and popd pointed out in #305 and #459.

pushd "${ROOT_DIR}"
gunzip "${ROOT_DIR}/${BASENAME}"
popd

where ROOT_DIR="${DOWNLOAD_DIR}/(name of database being downloaded)"

To my understanding, this code is entering the root dir, and then unzipping the file with root_dir in the path again. If the user-specified DOWNLOAD_DIR isn't the full path, then this will cause an error. If it is the full path, then pushd and popd are useless.

What would be the process for getting this fixed?

Thank you in advance!

@Augustin-Zidek Augustin-Zidek added the setup Issue setting up AlphaFold label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
setup Issue setting up AlphaFold
Projects
None yet
Development

No branches or pull requests

2 participants