Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scenarios clean_up_20 and territory__rooms_6 are wrong [v2.3] #246

Closed
duenez opened this issue Jun 27, 2024 · 2 comments
Closed

Scenarios clean_up_20 and territory__rooms_6 are wrong [v2.3] #246

duenez opened this issue Jun 27, 2024 · 2 comments
Assignees
@jagapiou
Labels
bug Something isn't working

Comments

@duenez
Copy link
Contributor

duenez commented Jun 27, 2024

Two scenarios used for the Melting Pot Competition have issues:

  • clean_up_20 is using the wrong (puppet) bot: clean_up__puppet_sanctioning_alternator_nice_0 instead of clean_up__puppet_sanctioning_alternator_0.
  • territory__rooms_6 is identical to territory__rooms_5.

The effective outcome is that the weight given to territory__rooms_5 and clean_up_19 are doubled.
@jagapiou jagapiou pinned this issue Jun 27, 2024
@duenez duenez added the bug Something isn't working label Jul 1, 2024
@duenez
Copy link
Contributor Author

duenez commented Jul 15, 2024

At head, clean_up_20 has been fixed. The tagged version 2.3.0 contains the mistake so it can be used to reproduce the state for the Melting Pot Competition 2023.

copybara-service bot pushed a commit that referenced this issue Dec 19, 2024
@jagapiou @copybara-github
Delete territory__rooms_6 as it is a duplicate of territory__rooms_5
a057515 
See: #246
PiperOrigin-RevId: 707851677
Change-Id: I272dc037b8e50dede332058c785308d6fbee747d
@jagapiou
Copy link
Member

Fixed and will be released in v2.4

@jagapiou jagapiou self-assigned this Dec 19, 2024
@jagapiou jagapiou changed the title Scenarios clean_up_20 and territory__rooms_6 are wrong Scenarios clean_up_20 and territory__rooms_6 are wrong [v2.3] Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jagapiou jagapiou

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jagapiou @duenez