-
Notifications
You must be signed in to change notification settings - Fork 626
The Pull Request Review Process
Beka Westberg edited this page May 1, 2020
·
8 revisions
You've already completed one massive hurtle by [writing your PR]. Now it goes through the next step which is the review process.
We believe that code improves as you gather diverse perspectives. Because of this all code goes through a review process to make sure it was seen by at least two people (you and your reviewer). Remember that everything your reviewer says is in the service of making the code better. Getting very few comments on a PR, or getting very many comments on a PR does not reflect you personally. You and your reviewer are working together to make your change as good as possible.
The PR review process goes through a few stages:
- Feedback
- Discussion
- Revision
- Repeat
- Merge!