Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v20240317 contains protobuf 3.17.0 instead of 3.25.2 #4168

Open
chschu opened this issue Jun 10, 2024 · 2 comments
Open

v20240317 contains protobuf 3.17.0 instead of 3.25.2 #4168

chschu opened this issue Jun 10, 2024 · 2 comments

Comments

@chschu
Copy link

chschu commented Jun 10, 2024

Regardless of what's specified in maven_artifacts.bzl, closure-compiler version v20240317 (and later builds) seem to contain protobuf-java version 3.17.0.

At least that's what META-INF/maven/com.google.protobuf/protobuf-java/pom.xml in https://repo1.maven.org/maven2/com/google/javascript/closure-compiler/v20240317/closure-compiler-v20240317.jar says. Local builds of the v20240317 tag or the current master contain the same information.

Version v20231112 contains protobuf-java version 3.21.12, which matches the version specified in maven_artifacts.bzl.

@brad4d
Copy link
Contributor

brad4d commented Jun 10, 2024

Thanks for reporting this.
It's not clear when the next release to Maven will occur, but I've added this issue to a list that will be resolved before it happens.

@gkdn
Copy link
Member

gkdn commented Dec 7, 2024

Since I am looking at the maven artifact, I just checked this.

pom.xml for the compiler correctly points to 3.21.12 which IIUC what matters here.

<dependency>
  <groupId>com.google.protobuf</groupId>
  <artifactId>protobuf-java</artifactId>
  <version>3.21.12</version>
</dependency>

The protobuf pom.xml in META-INF shouldn't be there; just seems like an artifact of the the way some jars are merged. However again IIUC it shouldn't have any impact.

Are you experiencing any problems?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants