New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit if using both SFSS and SFVSC is necessary #1117

Open

cstirdivant opened this issue Aug 2, 2023 · 1 comment

Assignees

Labels

Collaborator

cstirdivant commented Aug 2, 2023

SFVSC (and other speed control types) require the run status and command field, therefore including SFSS is extraneous.

We should either:

Remove run_command and run_status as required on the VSC types
Revise precedent so that if a canonical type uses a VSC type it does not need the SS type (explore if this has ramifications for downstream analytics)

Collaborator

shambergoldstein commented Aug 15, 2023

Also revisit if it makes sense to have speed_mode in the VSC types

cstirdivant self-assigned this

cstirdivant added the Ontology Model label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment