-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure the DRC rules have unit tests as well as bigger integration tests #15
Comments
@mithro The DRC tests are unit tests for each rule. Unfortunately, it's hard to isolate each rule as the DRc runs takes long time. All tests are integrated one GDS files and we could tell which rule had missed errors or false positive violations. There some parts of the regression system that are not integrated yet. @mohanad0mohamed will integrate them soon that detects each rule on its own. But it will be single run for most of the rules. |
We should split the GDS file apart so that each test has multiple small GDS files demonstrating one thing at a time. |
@mithro As we have discussed, we will split the GDS testing file to smaller test units per rule to be able to parallelize the run. |
Updating primitives names for 'npn' bjt devices in lvs gds files
It is general best practice to have lots of small units which only test one thing at a time. At the moment, the testing in #11 are more like integration tests.
The testing for the DRC rules should look like this -- for each DRC rule, there should be a directory which contains;
There should still be DRC integration tests, but they should only be run after all the individual unit tests are successful.
The text was updated successfully, but these errors were encountered: