Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply python linting and formatting rules to this repository #53

Closed
mithro opened this issue Aug 20, 2022 · 7 comments
Closed

Apply python linting and formatting rules to this repository #53

mithro opened this issue Aug 20, 2022 · 7 comments

Comments

@mithro
Copy link
Contributor

mithro commented Aug 20, 2022

A lot of the Python scripts are not complying with standard python formatting rules. We should enable tools which check the files are complaint.

Some tools which we should look at are;

  • pep8
  • black
  • pylint
  • Something which checks for trailing whitespace.
  • Something which checks for license headers.

Setting these up can be showing by looking at the F4PGA repositories.

@mithro
Copy link
Contributor Author

mithro commented Aug 20, 2022

@umarcor - Can you help here?

@atorkmabrains
Copy link
Collaborator

@mohanad0mohamed Could you please take a look here?

proppy pushed a commit to proppy/globalfoundries-pdk-libs-gf180mcu_fd_pr that referenced this issue Feb 6, 2023
…_update

update make file and python files to run from the make
@FaragElsayed2
Copy link
Collaborator

@atorkmabrains This issue has been addressed in PV repo

@atorkmabrains
Copy link
Collaborator

atorkmabrains commented Apr 9, 2023

@FaragElsayed2 I think here is different. We still need linting for the code related to Pcells.

@FaragElsayed2
Copy link
Collaborator

@atorkmabrains I have assumed that we will add new Pcell generators. And for regression used in models, linting issues have been fixed in Mabrains/PR repo.

@atorkmabrains
Copy link
Collaborator

Thanks @FaragElsayed2 I could see the linting issues has been fixed in Mabrains and Efabless versions.

@mithro Could we close this issue?

@atorkmabrains
Copy link
Collaborator

@mithro I have opened another issue for merging of Efabless updates #109 .

I'll close this issue. Please don't hesitate to open if you think we still need this issue. As soon as we update Google version with Efabless, we should have the linting code here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants