-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply python linting and formatting rules to this repository #53
Comments
@umarcor - Can you help here? |
@mohanad0mohamed Could you please take a look here? |
…_update update make file and python files to run from the make
@atorkmabrains This issue has been addressed in PV repo |
@FaragElsayed2 I think here is different. We still need linting for the code related to Pcells. |
@atorkmabrains I have assumed that we will add new Pcell generators. And for regression used in models, linting issues have been fixed in Mabrains/PR repo. |
Thanks @FaragElsayed2 I could see the linting issues has been fixed in Mabrains and Efabless versions. @mithro Could we close this issue? |
A lot of the Python scripts are not complying with standard python formatting rules. We should enable tools which check the files are complaint.
Some tools which we should look at are;
pep8
black
pylint
Setting these up can be showing by looking at the F4PGA repositories.
The text was updated successfully, but these errors were encountered: