Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few minor bugs #19

Open
jpaulynice opened this issue Feb 19, 2016 · 2 comments
Open

Few minor bugs #19

jpaulynice opened this issue Feb 19, 2016 · 2 comments

Comments

@jpaulynice
Copy link

Hi,

While investigating some slow issue with re2j compared to java regular expression, I found a few issues that I am planning to create a PR for:

See these 2 commits I have in my branch (don't worry about the System.out.print lines):

  1. jpaulynice@af6e399
  2. jpaulynice@3ea3aef

Question:
private void free(Thread t) method is not used in Machine.java what was the intention?

Regards,

Jay

@adonovan
Copy link
Collaborator

I think 'free' was a relic from the Go implementation; it used a freelist to reduce the cost of memory allocation, which is (or at least, was then), higher in Go than on the JVM.

@jpaulynice
Copy link
Author

I see thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants