Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent rendering Key Metrics if setup not completed #10074

Open
1 task
jimmymadon opened this issue Jan 20, 2025 · 0 comments
Open
1 task

Prevent rendering Key Metrics if setup not completed #10074

jimmymadon opened this issue Jan 20, 2025 · 0 comments
Assignees

Comments

@jimmymadon
Copy link
Collaborator

Bug Description

@aaemnnosttv: This isn't a particularly realistic scenario.

Steps to reproduce

  1. Setup and enable the KMW widget.
  2. In the database, delete the googlesitekit_key_metrics_setup_completed_by
  3. Refresh the dashboard and the key metrics still render alongside the Key metrs Setup CTA Banner.

Screenshots

Image

Additional Context

  • PHP Version:
  • OS: [e.g. iOS]
  • Browser: [e.g. chrome, safari]
  • Plugin Version: [e.g. 22]
  • Device: [e.g. iPhone6]

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@jimmymadon jimmymadon self-assigned this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant