Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a test against Showcase returning metadata as bytes #2294

Open
ohmayr opened this issue Dec 11, 2024 · 2 comments
Open

Implement a test against Showcase returning metadata as bytes #2294

ohmayr opened this issue Dec 11, 2024 · 2 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@ohmayr
Copy link
Contributor

ohmayr commented Dec 11, 2024

Update showcase to test metadata with bytes and add a unit test to confirm this behaviour.

@vchudnov-g
Copy link
Contributor

This is an issue with the Showcase server not returning the metadata? Then we should file an issue in gapic-showcase to provide that functionality, restrict this issue to be testing that functionality in the generator, and make this issue dependent on that one.

When filing the issue on Showcase, could you be more specific about that is missing: what service and RPC under which conditions does not return metadata?

@vchudnov-g vchudnov-g added type: process A process-related concern. May include testing, release, or the like. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Dec 18, 2024
@vchudnov-g vchudnov-g assigned ohmayr and unassigned vchudnov-g Dec 18, 2024
@vchudnov-g vchudnov-g changed the title showcase doesn't return metadata with bytes Implement a test against Showcase returning metadata as bytes Jan 7, 2025
@vchudnov-g
Copy link
Contributor

This would require changing Showcase so that when the metadata key as a suffix -bin, it returns data of type bytes. Ref

We should still file the necessary issue in the Showcase repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

2 participants