Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Loading text from the loading screen in production build #25

Open
keiffer01 opened this issue Jun 30, 2020 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@keiffer01
Copy link
Collaborator

Issue summary

Authenticating the current user is not instantaneous, and so for a split second the user is able to see the page load before Firebase realizes that they are not currently signed in and kicks them back to the landing page. This may be a problem if the user is able to, even temporarily, see the details of a trip itinerary. A fix for this could be a simple loading screen that hides page contents, which is only removed after the user has been authenticated.

Expected behavior

Page details are completely hidden from the user until they have been authenticated.

Actual behavior

Page continues to load even while the user is still being authenticated.

@keiffer01 keiffer01 added the enhancement New feature or request label Jun 30, 2020
@keiffer01 keiffer01 self-assigned this Jun 30, 2020
@keiffer01
Copy link
Collaborator Author

UPDATE: Using React, the page is simply not loaded until the user is fully authenticated. The browser temporarily shows a blank screen that says "Loading..." while this happens. This is left in for testing purposes, in the deployed build the loading screen should be made blank (since the authentication happens relatively quickly, the split second blank screen should be fine).

The title of this issue has been renamed from "Add simple loading screen to all pages (except the landing page)" to "Remove Loading text from the loading screen in production build".

@keiffer01 keiffer01 changed the title Add simple loading screen to all pages (except the landing page) Remove Loading text from the loading screen in production build Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant