Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting "Failed to clear clipboard history" on GNOME #1209

Closed
ndrewtl opened this issue Nov 12, 2019 · 2 comments · Fixed by #1247
Closed

Getting "Failed to clear clipboard history" on GNOME #1209

ndrewtl opened this issue Nov 12, 2019 · 2 comments · Fixed by #1247

Comments

@ndrewtl
Copy link

ndrewtl commented Nov 12, 2019 •
edited
Loading

Summary

When using gopass --clip [item], the item copies as normal. But after 45 seconds, I get a notification:

gopass - clipboard
Failed to clear clipboard history

Steps To Reproduce

Copy a secret using gopass --clip. Wait for it to attempt to clear.

Expected behavior

The password should clear, with no problem notification

Environment

Fedora 31

$ gopass --version
gopass 1.8.6-git+HEAD go1.13.3 linux amd64
$ gnome-shell --version
GNOME Shell 3.34.1
$ go version
go version go1.13.3 linux/amd64
$ dnf info wl-clipboard
Installed Packages
Name         : wl-clipboard
Version      : 1.0.0
Release      : 0.2.20181215git7e5103c.fc31
Architecture : x86_64
Size         : 107 k
Source       : wl-clipboard-1.0.0-0.2.20181215git7e5103c.fc31.src.rpm
Repository   : @System
From repo    : fedora
Summary      : Command-line copy/paste utilities for Wayland
URL          : https://github.com/bugaevc/wl-clipboard
License      : GPLv3+
Description  : Command-line Wayland clipboard utilities, `wl-copy` and `wl-paste`,
             : that let you easily copy data between the clipboard and Unix pipes,
             : sockets, files and so on.

Additional context

N/A
@ndrewtl
Copy link
Author

ndrewtl commented Nov 12, 2019 •
edited
Loading

Screenshot from 2019-11-12 11-48-03
Screenshot

@simonkrenger
Copy link
Contributor

simonkrenger commented Feb 5, 2020 •
edited
Loading

Seeing the same issue on my machine.

In https://github.com/gopasspw/gopass/blob/master/pkg/clipboard/unclip_linux.go#L18 it currently looks like on Linux klipper is being tried to be used to clear the clipboard history. However the password is definitely being overwritten in https://github.com/gopasspw/gopass/blob/master/pkg/clipboard/unclip.go

It turns out that DBus returns "The name is not activatable", which is not caught and results in this error.

@simonkrenger simonkrenger mentioned this issue Feb 5, 2020
Merged
dominikschulz pushed a commit that referenced this issue Apr 24, 2020
@simonkrenger
Catch 'The name is not activatable' DBus error when unclipping (#1247)
beb22bc 
On Fedora 31, `gopass unclip` fails with a "Failed to clear clipboard history"
notification. This is because DBus returns the following error message as
`klipper` is not available:

```
The name is not activatable
```

This commit adds this error message to the strings being ignored.

Fixes #1209

Signed-off-by: Simon Krenger <skrenger@redhat.com>
kpitt pushed a commit to kpitt/gopass that referenced this issue Jul 21, 2022
@simonkrenger
Catch 'The name is not activatable' DBus error when unclipping (gopas…
86b8aac 
…spw#1247)

On Fedora 31, `gopass unclip` fails with a "Failed to clear clipboard history"
notification. This is because DBus returns the following error message as
`klipper` is not available:

```
The name is not activatable
```

This commit adds this error message to the strings being ignored.

Fixes gopasspw#1209

Signed-off-by: Simon Krenger <skrenger@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Catch 'The name is not activatable' DBus error when unclipping
2 participants
@simonkrenger @ndrewtl