-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spruce Up ESLint Config #25
Comments
Hello! Looking through https://github.com/grafana/eslint-config-grafana/blob/489cd69/index.js, the biggest note from me is that there are a lot of manually configured rules. TypeScript ESLint has recommended preset configs you can extend from that are improved over time: https://typescript-eslint.io/docs/linting/configs. I'd suggest trying out the
I'd be happy to send a PR if you're interested, and/or help enable some of these rules - let me know! |
Hey Josh! Thanks so much for the input 😄 and in terms of strategy that certainly sounds like a good idea. If you'd like to submit a PR it would certainly be welcome. I'm deep in some other things this week and off next week, but I'm happy to track progress and otherwise I should be able to dive in myself once I get back. |
Fantastic! I filed a couple of PRs for your viewing pleasure: |
Thanks so much Josh, this is absolutely awesome! I'll take a look at these and start testing, I'm not 100% sure I'll be able to get to it this week but if not I will do so first thing once I'm back after being off. |
Happened to serendipitously run into @JoshuaKGoldberg at a local coding meetup and he's graciously offered to give our ESLint config a once over. In particular he mentioned there were a number of presets we could use to reduce the number of rules we're currently using. Will defer to his expertise there but will otherwise be following up with this.
The text was updated successfully, but these errors were encountered: