Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor crypto_test.go #4268

Open
olegbespalov opened this issue Oct 30, 2024 · 1 comment
Open

Refactor crypto_test.go #4268

olegbespalov opened this issue Oct 30, 2024 · 1 comment

Comments

@olegbespalov
Copy link
Contributor

What?

The original implementation of the WebCrypto API kept static Deplatform tests in the repository. That's approach was fine for the beginning, but less maintainable since we weren't able easily to answer the question of what's the difference between our version and original version of the test case from the web platform test suite.

Likely in grafana/xk6-webcrypto#87 and grafana/xk6-webcrypto#90 we adjusted that and started to use original suite of tests, with the patches applied on top of it, but that was done only for subtle_crypto_test.go. crypto_test.go still have static versions of the tests.

It's probably good to do align crypto_test.go and run the tests against the web platform tests, rather the static versions.

Why?

Running tests against WebPlatfrom test suite guaranties that our implementation compliant with the WebCrypto API specs, and if there are some differences we could easily store them as patches which makes it more transparent for our customers.

@olegbespalov olegbespalov transferred this issue from grafana/xk6-webcrypto Jan 22, 2025
@aniqaqill
Copy link

#4274

create a PR but the test case are unlikely fully covered may have some advice from you guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants