Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#42 #44

Closed
github-actions bot opened this issue Oct 11, 2023 · 1 comment
Closed

#42 #44

github-actions bot opened this issue Oct 11, 2023 · 1 comment
Assignees
Labels
duplicate This issue or pull request already exists todo

Comments

@github-actions
Copy link

https://api.github.com/groton-school/blackbaud-to-google-group-sync/blob/6c30da3acbb2f3f1756fa7df850b0dc4daa18750/src/server/Workflows/sync.php#L125

            /** @var DirectoryMember $gMember */
            if (array_key_exists($gMember->getEmail(), $bbMembers)) {
                unset($bbMembers[$gMember->getEmail()]);
            /*
             * TODO #42
             *   Appears that listMembers() returns an array of Member-like
             *   objects, but not actually members. They are missing the
             *   `delivery_settings` field. Which means that to get the
             *   delivery settings for each member, each member would need to
             *   be individually queried per group, which is prohibitively
             *   resource expensive.
             */
                /*
            if ($gMember->getDeliverySettings() != $deliverySettings) {
                $oldDeliverySettings = $gMember->getDeliverySettings();
                $gMember->setDeliverySettings($deliverySettings);
                $gMember = $directory->members->update(
                    $bbGroup->getParamEmail(),
                    $gMember->getId(),
                    $gMember
                );
                $listProgress->setStatus(
                    "Updated {$gMember->email} delivery_settings from to '{$gMember->getDeliverySettings()}'"
                );
            }
            */
            } else {
                if (
                    ($gMember->getRole() !== 'OWNER' ||
@github-actions github-actions bot added the todo label Oct 11, 2023
@battis battis added the duplicate This issue or pull request already exists label Oct 11, 2023
@battis
Copy link
Member

battis commented Oct 11, 2023

Duplicate of #42

@battis battis marked this as a duplicate of #42 Oct 11, 2023
@battis battis closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists todo
Projects
None yet
Development

No branches or pull requests

1 participant