Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to Cross Compile #106

Open
Uglymotha opened this issue Oct 17, 2024 · 3 comments
Open

Unable to Cross Compile #106

Uglymotha opened this issue Oct 17, 2024 · 3 comments

Comments

@Uglymotha
Copy link

Currently it is not possible to cross compile gssproxy. This is due to two autoconf macros.

  1. In external/dinglibs.m4 AC_RUN_IFELSE is used without cross compile action, leading to error: cannot run test program while cross compiling.
  2. In external/docbook.m4 AC_CHECK_FILE is used, leading to error: cannot check for file existence when cross compiling

I propose to fix 1. by adding a cross compile action to AC_RUN_IFELSE displaying a warning message for the user to make sure libini_config supports extended INI_MS_DETECT and maybe also fix the stale URL (https://pagure.io/SSSD/ding-libs/pull-request/3172) in the current error message. Maybe the test can just be removed altogether.

2 Can be simply fixed by replacing AC_CHECK_FILE with an explicit if ! test .....

If you concur, I can prepare a PR.
@simo5
Copy link
Contributor

simo5 commented Oct 17, 2024

A PR is good, the only question is whether it is possible to add a test in CI to make sure it stays working in the future.

@Uglymotha
Copy link
Author

I've been doing some looking around for the stale URL. Is this the issue that should be linked?
https://pagure.io/SSSD/ding-libs/issue/3167

@simo5
Copy link
Contributor

simo5 commented Oct 22, 2024

You can remove it if it is not an issue anymore

Uglymotha pushed a commit to Uglymotha/gssproxy that referenced this issue Oct 25, 2024
Fix cross compilation
f459188 
Fixes Issue 106 (gssapi#106)

modified:   external/dinglibs.m4
A warning message is displayed to the user to make sure lib_ini_config
supprts extenden INI_MS_DETECT, since the test cannot be run in a cross
compilation scenario.
modified:   external/docbook.m4
Autoconf Macro AC_CHECK_FILE has been replaced by an explicit if ! test
-e ..., as AC_CHECK_FILE is not available in cross compilation scenario.
@Uglymotha Uglymotha mentioned this issue Oct 25, 2024
Open
Uglymotha pushed a commit to Uglymotha/gssproxy that referenced this issue Oct 25, 2024
Fix cross compilation
76c5a43 
Fixes Issue 106 (gssapi#106)

modified:   external/dinglibs.m4
A warning message is displayed to the user to make sure lib_ini_config
supprts extenden INI_MS_DETECT, since the test cannot be run in a cross
compilation scenario.
modified:   external/docbook.m4
Autoconf Macro AC_CHECK_FILE has been replaced by an explicit if ! test
-e ..., as AC_CHECK_FILE is not available in cross compilation scenario.

Signed-off-by: Sietse van Zanen <uglymotha@wizdom.nu>
Uglymotha pushed a commit to Uglymotha/gssproxy that referenced this issue Oct 29, 2024
Fix cross compilation
aaeacfb 
Fixes Issue 106 (gssapi#106)

modified:   external/dinglibs.m4
A warning message is displayed to the user to make sure lib_ini_config
supprts extenden INI_MS_DETECT, since the test cannot be run in a cross
compilation scenario.
modified:   external/docbook.m4
Autoconf Macro AC_CHECK_FILE has been replaced by an explicit if ! test
-e ..., as AC_CHECK_FILE is not available in cross compilation scenario.

Signed-off-by: Sietse <sietse@wizdom.nu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simo5 @Uglymotha