Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of useIsAndroid hook #12868

Open
CDicksonG opened this issue Nov 19, 2024 · 3 comments · May be fixed by #12987
Open

Get rid of useIsAndroid hook #12868

CDicksonG opened this issue Nov 19, 2024 · 3 comments · May be fixed by #12987
Assignees
@marjisound
Milestone
Decommission Temp...

Comments

@CDicksonG
Copy link
Collaborator

Get rid of hack that limits number of articles in related content
@CDicksonG CDicksonG added this to the Decommission Templates milestone Nov 19, 2024
@SiAdcock SiAdcock changed the title Get rid of "Android Hack" Get rid of useIsAndroid hook Nov 19, 2024
@marjisound marjisound self-assigned this Dec 11, 2024
@SiAdcock
Copy link
Contributor

blocked until the horizontal scroll PR is android is released to prod

@marjisound marjisound linked a pull request Jan 13, 2025 that will close this issue
Remove useIsAndroid Hook and add Support for Horizontal Scrolling #12987
Open
@marjisound
Copy link
Contributor

marjisound commented Jan 13, 2025 •
edited
Loading

DCR PR #12987 is ready but it can only be merged after both ios and android have bridget version 8.3.2 in prod.

android: https://github.com/guardian/android-news-app/pull/11166
ios: https://github.com/guardian/ios-live/pull/8449

@marjisound
Copy link
Contributor

The DCR PR #12987 can only get merged after we see bridget version v8.3.2 in production (the production label is added to this PR https://github.com/guardian/android-news-app/pull/11166)

SO until then, this ticket is blocked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marjisound marjisound

Labels
None yet
Projects
None yet
Milestone
Decommission Templates
Development

Successfully merging a pull request may close this issue.

Remove useIsAndroid Hook and add Support for Horizontal Scrolling guardian/dotcom-rendering
3 participants
@SiAdcock @marjisound @CDicksonG