src() doesn't work with wildcards (4.0.2 -> 5.0.0)

[lik3as]

What were you expecting to happen?

all html files in src/html/**/*.html to be in the dist/ directory

What actually happened?

none of the files were in the dist/ dir

Please give us a sample of your gulpfile

gulp.task("build-html", async function () {
  return gulp
    .src("src/html/**/*.html")
    .pipe(
      fileinclude({
        context: layout,
        prefix: "@@",
        basepath: "@file",
        indent: true,
      })
    )
    .pipe(gulp.dest("dist"));
});

Terminal output / screenshots

$ yarn gulp build-html
$ ls dist/

Please provide the following information:

• OS & version: Ubuntu 22.04.4 (WSL 2)
• node version: 22.0.0
• npm version: 9.6.4
• gulp version: 5.0.0

Additional information

When using 4.0.2, the program works as expected. So the current solution is downgrading the gulp version.

[emimoun2]

i have the same issue
its copy part of file

[phated]

What happens if you remove async on your function? You can't combine promise-returning and stream-returning functions.

[lik3as]

What happens if you remove async on your function? You can't combine promise-returning and stream-returning functions.

this happens:
[15:34:34] The following tasks did not complete: build-html
[15:34:34] Did you forget to signal async completion?
error Command failed with exit code 1.

(i accidentally closed the issue)

[phated]

Sounds like your fileinclude plugin is broken, maybe it is emitting an error that's being lost.

Gulp 5 changed the underlying stream implementation and misbehaving stream implementations aren't supported anymore.

[lik3as]

I tested and the error still occurs when I remove fileInclude:

Also, it runs normally when using the callback (but still doesn't include all glob matching files)

[redmnat]

I have the exact same issue coming from 4.0.2. Using a simple src to dest stream fails with "Did you forget to signal async completion?" when using a wildcard.

Works:
gulp.src('src/index.html')

Fails:
gulp.src('src/*.html')

[ealcantara22]

I have the same issue, I started migrating to gulp v5 and faced this.

gulp: v5.0.0
node: v20.14.0
npm: 10.7.0
macOS: 14.6.1 Sonoma

[thomjjames]

Also getting this with Gulp 5, downgrading to version 4 and it seems to work ok:

yarn add gulp@4

[vincenzo-antolini-os]

I’m encountering a similar issue with what seems like the simplest, most “basic” task Gulp could be asked to perform. I hate to even bring it up, but....

Working code:
gulp.src('src/scss/main.scss')

Failing code:
gulp.src('src/scss/**/*.scss')

Yes, that’s right: just a humble attempt to match multiple .scss files in a directory. Is there something that Gulp 5 has against the **/*.scss pattern? This feels so "elemental" that it almost hurts to ask.

Any pointers would be appreciated. I’m really hoping this is just something obvious that I’m overlooking.

[b-commits]

Having upgraded from 4.0.2 to 5.0.0, I've also started seeing issues with this minimal Gulp task:

async function copy() {
    return gulp
        .src("wwwroot/lib/library1/folder1/**/*.{ttf}", {
            base: "wwwroot/lib/library1",
        })
        .pipe(gulp.dest("wwwroot/dist"));
}

No files are copied and I triple checked they are in the source folder. If I remove the wildcards and explicity state the folder and file names, it copies over to the dist folder just fine.

Any workarounds that will still allow me to use wildcards?

"npm": "^10.9.2"
node v21.6.0

[brunnopleffken]

I'm having trouble getting this to work after upgrading from gulp 4.0.2 to 5.0.0. The examples in the documentation do not include an async implementation, so they are useless.

[14:02:19] The following tasks did not complete: default
Did you forget to signal async completion?

With this simple task:

const { src, dest } = require('gulp');
const rename = require('gulp-rename');
const sass = require('gulp-sass')(require('sass'));

exports.default = function () {
  return src('./public/src/css/application.scss')
    .pipe(sass({ outputStyle: 'compressed' }))
    .pipe(rename({ extname: '.min.css' }))
    .pipe(dest('public/dist/'));
}