-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] pyproject.toml file not found #249
Comments
I see this is a duplicate of #228.. can you fix this issue please? @hadialqattan |
Hi, Opened a PR that should fix this: #250 |
Does anyone know a workaround for pre-commit in CI? Also: Why does this start failing now? There didn't seem to be any changes in this repo or in our pre-commit config. I'm perplexed. |
I am also getting the same error in a GitHub workflow which has I am surprised about why I am getting this error today when I have been using this same config for more than an year. |
+1 |
+1 |
1 similar comment
+1 |
sorry for being late, please use |
@or150 or @hadialqattan can you please help me understand how did previous versions fail in CI? How does a bug enter an existing version of the project without config changes? |
It doesn't unless your CI system uses the latest version of Poetry (poetry-core v2). |
I am using poetry version 1.5.1 which uses poetry-core version 1.6.1 as per GitHub release. So I don't think this is the case for me.
|
Describe the bug A clear and concise description of what the bug is.
I'm getting an error when running
pycln
usingpre-commit
:Though it's important to note that this doesn't happen if I install pre-commit using pipx or (pip in its own virtual environment).
To Reproduce Steps to reproduce the behavior:
Some minimal setup for pre-commit + pycln:
Run Pycln via pre-commit:
Error traceback:
Expected behavior:
Environment (please complete the following informations):
Additional context Add any other context about the problem here.
I debugged the issue abit. Taking a look at the error message, it seems that it is trying to look for
pycln
's pyproject.toml file inside the site_packages directory, which I thought was a bit weird.But then if I install
pycln
usingpipx
, and take a look at the environment set up there:$ pipx environment --value PIPX_HOME /Users/xxx/Library/Application Support/pipx $ ls -l "/Users/xxx/Library/Application Support/pipx/venvs/pycln/lib/python3.10/site-packages/" ... pycln pycln-2.4.0.dist-info ... pyproject.toml
pycln's pyprojet.toml appears in the site-packages, which is why it works when installed via pipx.
Is there an issue with the installation here or it's expected to be be polluting the site-packages directory with pycln's own pyproject.toml? seems like an off-by-one directory bug...?
The text was updated successfully, but these errors were encountered: