Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elixir 1.4 warnings #125

Open
russmatney opened this issue Feb 9, 2017 · 1 comment
Open

Elixir 1.4 warnings #125

russmatney opened this issue Feb 9, 2017 · 1 comment

Comments

@russmatney
Copy link
Contributor

I'm seeing a handful of warnings when compiling on elixir 1.4, so am approaching a PR to clean these up. Hope to get to it in the next few days, but I thought I'd drop a line here to be sure I wasn't recreating any work if anyone else is working on this.

I'm also curious what your thoughts are on including @specs on functions throughout – it helps a ton with maintainability. For example, this line would be much easier to reason about (Keyword.put_new/3, or Map.put_new/3?) if the function had a spec describing the types.

@norpan
Copy link
Contributor

norpan commented Sep 27, 2017

I let all the warnings be when I made a patch, but perhaps it would be good to remove all warnings in the master branch so that we don't have to deal with this every time we make a patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants