Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnect Button broken with patch 27.4 #23

Open
plivanos opened this issue Sep 20, 2023 · 39 comments
Open

Reconnect Button broken with patch 27.4 #23

plivanos opened this issue Sep 20, 2023 · 39 comments

Comments

@plivanos
Copy link

Hello, patch 27.4 broke the reconnect button again!

@hizenzen
Copy link

true dat

@NotThatMiko
Copy link

+1

@Splendent
Copy link

nah...HDT remove it from available plugin, no idea why

@tartru-std
Copy link

In the commit they said "Blizzard has kindly asked us to stop supporting this plugin"
They are juste doing a check on the plugin name. I suppose that you can just change the plugin name and it will work again.
HDT commit : HearthSim/Hearthstone-Deck-Tracker@157187b

@hizenzen
Copy link

hizenzen commented Sep 20, 2023 via email

@tartru-std
Copy link

tartru-std commented Sep 20, 2023

Use a random value instead of an hardcoded string for the plugin name and it will do the trick

@Koen-Moore
Copy link

Use a random value instead of an hardcoded string for the plugin name and it will do the trick

What is the easiest way to do that? I tried changing the name of the DLL and it didn't work

@maxrenke
Copy link

the dll needs to be recompiled with a new name... if only haoruan shared build instructions 🤔

@SaveZelda
Copy link

SaveZelda commented Sep 21, 2023

Fuck blizzard and their slow ass animations. They want to force us watching their shit,but most people only care about the end result and don't want to waste time watching the animations

Blizzard is a dumbass company, period. The only thing they know is how to ruin players experience and destroy their own IPs

@st0rch
Copy link

st0rch commented Sep 21, 2023

I got it to work in like 10 minutes.

  1. Clone the repo

  2. In the ReconnectorPlugin.cs file, change the value of the "Name" property to whatever you want

    • I changed any class name referencing "Reconnector" to be safe, but It's almost certainly just this one property as the above commit from the HSDeckTracker devs showed the code looking for plugin.name, and this file contains all of the info about the plugin and inherits from their plugin interface.
  3. Build the project, which will put the DLL file (and a bunch of other garbage) in your Bin folder.

  4. Drop it in the HDT plugin folder and you're good to go.

I can share the rebuilt plugin, or if you'd rather rebuild it just follow these instructions.

@hizenzen
Copy link

hizenzen commented Sep 21, 2023

Yeah, I got it working as well.

@Doud78
Copy link

Doud78 commented Sep 21, 2023

Hey storch, how do you build the project ?

@hizenzen
Copy link

Visual Studio

@Doud78
Copy link

Doud78 commented Sep 21, 2023

yes, but how, like i ve put the project in VS and then what u do? sry for those stupid questions

@hizenzen
Copy link

Control+B or or go to Build/Build HDT-Reconnector

@ladragee
Copy link

works fine thx

@Reachground
Copy link

Can you share it @st0rch?

@Shaplow
Copy link

Shaplow commented Sep 21, 2023

Yeah it will be nice if u can share it @st0rch, i try to rebuild it but i fail aha

@hizenzen
Copy link

Here, this is a clone of haoruan's repo( I checked the license, this should be fine, but if haoruan has any problems with it, I can delete it right away).

https://github.com/hizenzen/HSReconnect/tree/HS_Reconnector

P.S I have also temporarily disabled the "Simulate" option, so there is only a "Reconnect" button now.

@meliodas991023
Copy link

meliodas991023 commented Sep 21, 2023

hizenzen the link you shared does not work

@hizenzen
Copy link

My bad, it was private, changed it to public

@meliodas991023
Copy link

thanks

@hizenzen
Copy link

btw, it seems like disabling the simulate broke something so there is a "key" text instead of reconnect, I'll fix this later

@TZUMITNEM
Copy link

Thanks a lot @hizenzen

@Reachground
Copy link

Reachground commented Sep 21, 2023

Awesome @hizenzen. Thanks! The "Key:" is funny but it reconnects!

EDIT: Pressed it and after that it's just grey. I really don't care that much, I'm just happy it works again!

@Shaplow
Copy link

Shaplow commented Sep 21, 2023 via email

@hizenzen
Copy link

hizenzen commented Sep 21, 2023

The reconnect button should be fixed now(download v1.4.8).
Anyway, renaming the plugin is just a temporary fix, I think HS deck tracker will find a better way to block this plugin soon .

@SaveZelda
Copy link

The reconnect button should be fixed now(download v1.4.8). Anyway, renaming the plugin name is just a temporary fix, I think HS deck tracker will find a better way to block this plugin soon .

Thanks so much hizenzen! The hero we need indeed :)

@hizenzen
Copy link

the zip from hizenzen is flagged by my AV

Then I guess haoruan's plugin is a virus as well.

Seriously, if you think it's a virus, simply don't use it. I only created this repo to help the other folks who can't compile the source code with VS.

@Reachground
Copy link

Installed the latest version. Thanks again @hizenzen! 🏆

Scanned it with my AV from work. Nothing as expected, kuroanon has to stop using Blizzard's Malware protection 😆

@daakal
Copy link

daakal commented Sep 22, 2023

you can just open the code in github and view it, its very short, its not a virus :) thank you hizenzen for the quick fix so i can get back to not rushing between turns 👍

@haoruan
Copy link
Owner

haoruan commented Sep 22, 2023

Here, this is a clone of haoruan's repo( I checked the license, this should be fine, but if haoruan has any problems with it, I can delete it right away).

https://github.com/hizenzen/HSReconnect/tree/HS_Reconnector

P.S I have also temporarily disabled the "Simulate" option, so there is only a "Reconnect" button now.

No problem at all, feel free to update it and thanks for making it work again.

I was notified several weeks ago: "HDT Reconnector plugin is not something they would like to exist for Hearthstone", and was asked to take it down and stop offering it. So I plan to remove the DLL files in the coming weeks but will still keep the source code so that everyone can compile the DLL themselves.

At last, this is not a functional bug and HDT may block this plugin again, so I won't fix it in this repo, you can refer to above comments for a workaround.

@Mentalist069
Copy link

Here, this is a clone of haoruan's repo( I checked the license, this should be fine, but if haoruan has any problems with it, I can delete it right away).

https://github.com/hizenzen/HSReconnect/tree/HS_Reconnector

P.S I have also temporarily disabled the "Simulate" option, so there is only a "Reconnect" button now.

stopped working. please update )

@Reachground
Copy link

Oh, I misunderstood. Downloaded that version but it didn't work. Of course not, it's the old version. Well let's see if someone can get it to work again. It's so annoying to see the slow fights.

@Mentalist069
Copy link

oh, yes). I really hope that @hizenzen will make an updated version

@geberten
Copy link

if u dont wanna wait for @hizenzen uninstall hdt and go to https://github.com/HearthSim/Hearthstone-Deck-Tracker/releases and dowland [v1.22.10] and make sure u close check for uptades.

@Mentalist069
Copy link

если ты не хочешь ждать@hizenzenудалите hdt и перейдите по адресу https://github.com/HearthSim/Hearthstone-Deck-Tracker/releases и dowland [v1.22.10] и убедитесь, что вы закрыли проверку на наличие обновлений.

Thanks I'll try

@Mentalist069
Copy link

если ты не хочешь ждать@hizenzenудалите hdt и перейдите по адресу https://github.com/HearthSim/Hearthstone-Deck-Tracker/releases и dowland [v1.22.10] и убедитесь, что вы закрыли проверку на наличие обновлений.

Thanks I'll try

yes, it works that way, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests