Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting BackLink to null does not work #2033

Closed
skoeva opened this issue Jun 10, 2024 · 0 comments · Fixed by #2034
Closed

Setting BackLink to null does not work #2033

skoeva opened this issue Jun 10, 2024 · 0 comments · Fixed by #2034
Assignees
@skoeva

Comments

@skoeva
Copy link
Contributor

skoeva commented Jun 10, 2024 •
edited
Loading

When trying to remove the backLink from the MainInfoSection component, setting it to null does not work. We can currently set it to the empty string "", but adding the boolean null could make it more obvious that we do not want to use the backLink. We should account for null in this case.

image
image
@skoeva skoeva self-assigned this Jun 10, 2024
skoeva added a commit that referenced this issue Jun 10, 2024
@skoeva
frontend: MainInfoSection: Correctly handle null backLink
3bbd95e 
This fix explicitly handles the null case in getBackLink() to ensure
that no back button will be shown, as defined in MainInfoSectionProps.

Fixes: #2033

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
@skoeva skoeva mentioned this issue Jun 10, 2024
Merged
3 tasks
@skoeva skoeva linked a pull request Jun 10, 2024 that will close this issue
frontend: Hide back button with null backLink #2034
Merged
3 tasks
skoeva added a commit that referenced this issue Jun 11, 2024
@skoeva
frontend: MainInfoSection: Correctly handle null backLink
c1f3f8c 
This fix explicitly handles the null case in getBackLink() to ensure
that no back button will be shown, as defined in MainInfoSectionProps.

Fixes: #2033

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva added a commit that referenced this issue Jun 11, 2024
@skoeva
frontend: MainInfoSection: Correctly handle null backLink
7cd0589 
This fix explicitly handles the null case in getBackLink() to ensure
that no back button will be shown, as defined in MainInfoSectionProps.

Fixes: #2033

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva added a commit that referenced this issue Jun 12, 2024
@skoeva
frontend: MainInfoSection: Correctly handle null backLink
6834205 
This fix explicitly handles the null case in getBackLink() to ensure
that no back button will be shown, as defined in MainInfoSectionProps.

Fixes: #2033

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva added a commit that referenced this issue Jun 14, 2024
@skoeva
frontend: MainInfoSection: Correctly handle null backLink
f119bcd 
This fix explicitly handles the null case in getBackLink() to ensure
that no back button will be shown, as defined in MainInfoSectionProps.

Fixes: #2033

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva added a commit that referenced this issue Jun 14, 2024
@skoeva @tazo90
frontend: MainInfoSection: Correctly handle null backLink
027f445 
This fix explicitly handles the null case in getBackLink() to ensure
that no back button will be shown, as defined in MainInfoSectionProps.

Fixes: #2033

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>

charts: fix oidc external secret loading

There was a wrong k8s config written for envFrom for external secret.

Fixes: #2022
Signed-off-by: Kautilya Tripathi <ktripathi@microsoft.com>

Remove unnecessary package.json and package-lock from root dir

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

frontend: Replace Create React App with Vite. Replace jest with vitest

Signed-off-by: Oleksandr Dubenko <oldubenko@microsoft.com>
Co-authored-by: Mariusz Winnik <tazo90@gmail.com>
@skoeva skoeva mentioned this issue Jun 14, 2024
Closed
3 tasks
skoeva added a commit that referenced this issue Jun 14, 2024
@skoeva
frontend: MainInfoSection: Correctly handle null backLink
5eeb2fe 
This fix explicitly handles the null case in getBackLink() to ensure
that no back button will be shown, as defined in MainInfoSectionProps.

Fixes: #2033

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva added a commit that referenced this issue Jun 14, 2024
@skoeva
frontend: MainInfoSection: Correctly handle null backLink
b31b82c 
This fix explicitly handles the null case in getBackLink() to ensure
that no back button will be shown, as defined in MainInfoSectionProps.

Fixes: #2033

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva added a commit that referenced this issue Jun 14, 2024
@skoeva
frontend: MainInfoSection: Correctly handle null backLink
1c6d7a6 
This fix explicitly handles the null case in getBackLink() to ensure
that no back button will be shown, as defined in MainInfoSectionProps.

Fixes: #2033

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva added a commit that referenced this issue Jun 21, 2024
@skoeva
frontend: Hide back button with null backLink
6aeb8b2 
This fix explicitly handles the null case in getBackLink() to ensure
that no back button will be shown, as defined in MainInfoSectionProps.

Fixes: #2033

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
skoeva added a commit that referenced this issue Jun 26, 2024
@skoeva
frontend: Hide back button with null backLink
84c4a1f 
This fix explicitly handles the null case in getBackLink() to ensure
that no back button will be shown, as defined in MainInfoSectionProps.

Fixes: #2033

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
joaquimrocha pushed a commit that referenced this issue Jun 26, 2024
@skoeva @joaquimrocha
frontend: Hide back button with null backLink
65e0a4f 
This fix explicitly handles the null case in getBackLink() to ensure
that no back button will be shown, as defined in MainInfoSectionProps.

Fixes: #2033

Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skoeva skoeva

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@skoeva