Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use retries/timeouts to improve reliabilty of downloads from S3 #74

Open
edmorley opened this issue Jul 20, 2023 · 1 comment
Open

Use retries/timeouts to improve reliabilty of downloads from S3 #74

edmorley opened this issue Jul 20, 2023 · 1 comment
Labels
classic buildpack parity Features required for parity with the classic Heroku Python buildpack

Comments

@edmorley
Copy link
Member

Currently the Python CNB makes a single download attempt for the Python runtime archive on S3.

We should add retries/timeouts to improve reliability in case there are network/S3 issues, similar to what the classic buildpack does.

Internal tracking epic

@edmorley edmorley added the classic buildpack parity Features required for parity with the classic Heroku Python buildpack label Jul 20, 2023
@edmorley
Copy link
Member Author

Example failure:

[Installing Python]
Installing Python 3.12.7

[Error: Unable to download Python]
An error occurred whilst downloading the Python runtime archive.

In some cases, this happens due to an unstable network connection.
Please try again and to see if the error resolves itself.

Details: https://heroku-buildpack-python.s3.us-east-1.amazonaws.com/python-3.12.7-ubuntu-24.04-arm64.tar.zst: Dns Failed: resolve dns name 'heroku-buildpack-python.s3.us-east-1.amazonaws.com:443': failed to lookup address information: Try again

ERROR: failed to build: exit status 1

(From: https://github.com/heroku/cnb-builder-images/actions/runs/11281440483/job/31376753868#step:6:21)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classic buildpack parity Features required for parity with the classic Heroku Python buildpack
Projects
None yet
Development

No branches or pull requests

1 participant