Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify construction of views #84

Open
wallento opened this issue Dec 4, 2021 · 0 comments
Open

Unify construction of views #84

wallento opened this issue Dec 4, 2021 · 0 comments

Comments

@wallento
Copy link
Contributor

wallento commented Dec 4, 2021

Currently the constructor for the LED matrix is exlicitly called, while others are constructor implicitly (better imo): https://github.com/hm-riscv/vscode-riscv-venus/blob/master/src/venusDebug.ts#L251
We should generalize openView by taking constructing arguments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wallento