Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatibility with jasmine.isSpy #30

Open
hmil opened this issue Feb 4, 2021 · 2 comments
Open

Incompatibility with jasmine.isSpy #30

hmil opened this issue Feb 4, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@hmil
Copy link
Owner

hmil commented Feb 4, 2021

The method jasmine.isSpy attempts to access "well known" members on omnimock:

https://github.com/jasmine/jasmine/blob/89331bb1bbda9a86f8eea7db43ee8605b414bff1/src/core/base.js#L347

Add and to the properties whitelist.
@hmil hmil added the bug Something isn't working label Feb 4, 2021
@hmil
Copy link
Owner Author

hmil commented Feb 4, 2021

To investigate: just return undefined on unexpected property accesses.

@hmil
Copy link
Owner Author

hmil commented Feb 19, 2021

Another workaround for this is to stop using jasmine expect since it's crap and instead expose an equivalent feature directly from omnimock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hmil