Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups with 0 Owners are not possible #360

Open
1 task
benn02 opened this issue Jan 25, 2023 · 3 comments
Open
1 task

Groups with 0 Owners are not possible #360

benn02 opened this issue Jan 25, 2023 · 3 comments
Assignees
Labels

Comments

@benn02
Copy link
Collaborator

benn02 commented Jan 25, 2023

User stories

As a User, I want Groups with 0 Owners to be not possible in order to not crash if they have none

Acceptance Criteria

  • Given a Group with exactly one owner that is not a system Group, then there is no Button for that owner to demote themselves or leave the group
@benn02 benn02 added this to the Permission and Login System milestone Jan 25, 2023
@Greenscreen23 Greenscreen23 self-assigned this Jan 30, 2023
@Greenscreen23
Copy link
Collaborator

I'm not really sure why this should be a feature. We currently have the option for groups that don't have a specific owner, so called "system groups". F.e. the default hpi group is working as intendend.

Is this ticket about these groups, or should users be able to create a group that does not have an owner?

@benn02
Copy link
Collaborator Author

benn02 commented Jan 30, 2023

If that is working as intended and you can choose these Groups When creating an Item as Groups with permissions then you could also implement that the last owner cant leave the group or demote himself because either way we dont want broken groups. Either by just saying they are not broken (the original idea of this issue) or by forcing group owners to stay in their group and not destroying it in the first place

@Greenscreen23
Copy link
Collaborator

Greenscreen23 commented Jan 30, 2023

If that is working as intended and you can choose these Groups When creating an Item as Groups with permissions then you could also implement that the last owner cant leave the group or demote himself because either way we dont want broken groups. Either by just saying they are not broken (the original idea of this issue) or by forcing group owners to stay in their group and not destroying it in the first place

I think it's reasonable to implement it like this:

  • Given a Group with exactly one owner that is not a system Group
  • Then there is no Button for that owner to demote themself or leave the group

And I don't change the underlying Model, e.g. groups are only valid if they are a System Group or they have at least one owner.

or is this something that's already being implemented by a different Team?

@benn02 benn02 changed the title Groups can have 0 Owners Groups with 0 Owners are deleted Jan 30, 2023
@benn02 benn02 changed the title Groups with 0 Owners are deleted Groups with 0 Owners are not possible Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants