Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppCompat dependency? #20

Closed
fitsuli opened this issue Jun 19, 2024 · 2 comments · Fixed by #21
Closed

AppCompat dependency? #20

fitsuli opened this issue Jun 19, 2024 · 2 comments · Fixed by #21
Labels
bug Something isn't working

Comments

@fitsuli
Copy link
Contributor

fitsuli commented Jun 19, 2024

Hi! Thank you for sharing this library. I was looking through your code and stumbled upon the AppCompat dependency on :bottomsheet module that doesn't appear to be used anywhere.

Since the AppCompat itself is relatively heavy, I was wondering is there a reason for you to have it as dependency?

@hrach
Copy link
Owner

hrach commented Jun 19, 2024

Thanks for pointing out. Yes, it seems we should remove it. Feel free to open PR or I'll fix it later.

@hrach hrach added the bug Something isn't working label Jun 19, 2024
@fitsuli
Copy link
Contributor Author

fitsuli commented Jun 19, 2024

Thanks for pointing out. Yes, it seems we should remove it. Feel free to open PR or I'll fix it later.

Here's a PR: #21

@hrach hrach closed this as completed in #21 Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants