Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid nested InheritFromOtherOptimizer #267

Open
NouamaneTazi opened this issue Jan 15, 2025 · 0 comments
Open

Avoid nested InheritFromOtherOptimizer #267

NouamaneTazi opened this issue Jan 15, 2025 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed Low Priority

Comments

@NouamaneTazi
Copy link
Member

We shouldn't pass a InheritFromOtherOptimizer to another InheritFromOtherOptimizer InheritFromOtherOptimizer(optimizer=InheritFromOtherOptimizer(), ...)

But when adding an assert and launch a training we do hit it (so we should fix init_optimizer_and_grad_accumulator)
Image

Shouldn't be a big issue, but we can avoid the additional nesting
@NouamaneTazi NouamaneTazi added good first issue Good for newcomers help wanted Extra attention is needed Low Priority labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed Low Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NouamaneTazi