Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group-include filter enhencement #29

Open
nt74 opened this issue Mar 1, 2023 · 3 comments
Open

group-include filter enhencement #29

nt74 opened this issue Mar 1, 2023 · 3 comments

Comments

@nt74
Copy link

nt74 commented Mar 1, 2023

Is it possible to insert a group-include filter with a multiple whitelist (regular expressions)?

Either by;
(1)
Comma separation reg.expression i.e. --group-include "News","Movies","Sports NBA"

(2)
A whitelist file which can contain all group-id.s to include, i.e.
News
Movies
Sports NBA

@huxuan
Copy link
Owner

huxuan commented Mar 2, 2023

Yes, it is possible, but actually I do not think it is necessary as group include currently support regex, you can write a somehow complicated regex to match those whitelists. What do you think of it?

@nt74
Copy link
Author

nt74 commented Mar 2, 2023

I tested some regex expressions out and they do work. So my answer will be Yes I am satisfied.
However in the documentation maybe there should be more information on how to use the regex syntax.

For example I used this expression to solve the above example:
--group-include 'News|Movies|\ASports NBA'

Should there be a special character like i.e. "+", this can be excluded (or included) in the regex like:
--group-include 'News|Movies|\ASports NBA|\ASports[+] NHL'

@huxuan
Copy link
Owner

huxuan commented Mar 6, 2023

Thanks for the response.
I will take a look and keep this issue open until it is properly handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants