Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Add "no proof check" option for VC decoding #1002

Closed
kdimak opened this issue Dec 20, 2019 · 2 comments · Fixed by #1012
Closed

Add "no proof check" option for VC decoding #1002

kdimak opened this issue Dec 20, 2019 · 2 comments · Fixed by #1012
Assignees
@kdimak
Labels
enhancement New feature or request
Milestone
0.1.1

Comments

@kdimak
Copy link
Contributor

kdimak commented Dec 20, 2019

As a result, we should bypass failing tests from VC Test Suite, see w3c/vc-test-suite#101 .
@kdimak kdimak mentioned this issue Dec 20, 2019
Open
26 tasks
@kdimak
Copy link
Contributor Author

kdimak commented Dec 20, 2019

I am about to start working on this issue.

@fqutishat fqutishat added the enhancement New feature or request label Dec 20, 2019
@fqutishat fqutishat added this to the 0.1.1 milestone Dec 20, 2019
kdimak added a commit to kdimak/aries-framework-go that referenced this issue Dec 20, 2019
@kdimak
feat: Add "no proof check" option for VC decoding
50e810b 
closes hyperledger-archives#1002

Signed-off-by: Dima <dkinoshenko@gmail.com>
@troyronda
Copy link
Contributor

troyronda commented Dec 20, 2019 •
edited
Loading

@kdimak I am thinking we should put this option behind a build tag testsuite, and then build the generator with this build tag.

(To do so, put the option into its own .go file and put a build tag constraint at the top of the file.)

kdimak added a commit to kdimak/aries-framework-go that referenced this issue Dec 20, 2019
@kdimak
feat: Add "no proof check" option for VC decoding
850df82 
closes hyperledger-archives#1002

Signed-off-by: Dima <dkinoshenko@gmail.com>
kdimak added a commit to kdimak/aries-framework-go that referenced this issue Dec 20, 2019
@kdimak
feat: Add "no proof check" option for VC decoding
24ae483 
closes hyperledger-archives#1002

Signed-off-by: Dima <dkinoshenko@gmail.com>
@kdimak kdimak mentioned this issue Dec 20, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kdimak kdimak

Labels
enhancement New feature or request
Milestone
0.1.1
Development

Successfully merging a pull request may close this issue.

feat: Add "no proof check" option for VC decoding kdimak/aries-framework-go
3 participants
@troyronda @fqutishat @kdimak