From 110890f02b82e2c6207fe222b83644ec2bb9e796 Mon Sep 17 00:00:00 2001 From: Hyperledger Bot Date: Fri, 17 Nov 2023 04:28:50 -0800 Subject: [PATCH] Update PRs (#5453) --- .../hyperledger-labs/open-enterprise-agent.md | 108 ------------------ .../hyperledger/aries-cloudagent-python.md | 39 +++++++ pull-requests/hyperledger/besu.md | 36 +++++- pull-requests/hyperledger/cacti.md | 47 -------- pull-requests/hyperledger/iroha-java.md | 26 ----- pull-requests/hyperledger/solang.md | 27 ----- trending/recent-prs.md | 8 +- 7 files changed, 78 insertions(+), 213 deletions(-) diff --git a/pull-requests/hyperledger-labs/open-enterprise-agent.md b/pull-requests/hyperledger-labs/open-enterprise-agent.md index 592f24fe4..c521ee3ef 100644 --- a/pull-requests/hyperledger-labs/open-enterprise-agent.md +++ b/pull-requests/hyperledger-labs/open-enterprise-agent.md @@ -336,111 +336,3 @@ Fixes ATL-3320 -
- - - - - - - - - -
- PR #784 - - - chore(castor): clean up sonarcloud issues and unused configurations - -
- castorprism-agentinfra - - # Overview - - -Partially fixes ATL-5374. Clean up some warning from sonarcloud analysis and remove unused configurations. - -## Checklist - -### My PR contains... -* [x] No code changes (changes to documentation, CI, metadata, etc.) -* [ ] Bug fixes (non-breaking change which fixes an issue) -* [ ] Improvements (misc. changes to existing features) -* [ ] Features (non-breaking change which adds functionality) - -### My changes... -* [ ] are breaking changes -* [x] are not breaking changes -* [ ] If yes to above: I have updated the documentation accordingly - -### Documentation -* [ ] My changes do not require a change to the project documentation -* [ ] My changes require a change to the project documentation -* [ ] If yes to above: I have updated the documentation accordingly - -### Tests -* [ ] My changes can not or do not need to be tested -* [ ] My changes can and should be tested by unit and/or integration tests -* [ ] If yes to above: I have added tests to cover my changes -* [ ] If yes to above: I have taken care to cover edge cases in my tests - -
-
- Created At 2023-11-10 10:19:34 +0000 UTC -
-
- -
- - - - - - - - - -
- PR #783 - - - fix(prism-agent): more descriptive error response for validateDID in issue flow - -
- castorprism-agent - - # Overview - - -Fixes ATL-6156 - -## Checklist - -### My PR contains... -* [ ] No code changes (changes to documentation, CI, metadata, etc.) -* [x] Bug fixes (non-breaking change which fixes an issue) -* [ ] Improvements (misc. changes to existing features) -* [ ] Features (non-breaking change which adds functionality) - -### My changes... -* [ ] are breaking changes -* [x] are not breaking changes -* [ ] If yes to above: I have updated the documentation accordingly - -### Documentation -* [x] My changes do not require a change to the project documentation -* [ ] My changes require a change to the project documentation -* [ ] If yes to above: I have updated the documentation accordingly - -### Tests -* [ ] My changes can not or do not need to be tested -* [ ] My changes can and should be tested by unit and/or integration tests -* [ ] If yes to above: I have added tests to cover my changes -* [ ] If yes to above: I have taken care to cover edge cases in my tests - -
-
- Created At 2023-11-10 08:11:00 +0000 UTC -
-
- diff --git a/pull-requests/hyperledger/aries-cloudagent-python.md b/pull-requests/hyperledger/aries-cloudagent-python.md index 5bb8d6e92..901ed02bb 100644 --- a/pull-requests/hyperledger/aries-cloudagent-python.md +++ b/pull-requests/hyperledger/aries-cloudagent-python.md @@ -10,6 +10,45 @@ permalink: /pull-requests/hyperledger/aries-cloudagent-python # aries-cloudagent-python [GitHub](https://github.com/hyperledger/aries-cloudagent-python){: .btn .mr-4 } +
+ + + + + + + + + +
+ PR #2612 + + + :bug: fix wallet_update when only `extra_settings` requested + +
+ + + Minor bug fix: `wallet_update` has a condition: + +```py + if all( + v is None for v in (wallet_webhook_urls, wallet_dispatch_type, label, image_url) + ): + raise web.HTTPBadRequest(reason="At least one parameter is required.") +``` + +This ignores the newly added `extra_settings`, and so trying to update a wallet with only `extra_settings` in the request raises a faulty Bad Request: "At least one parameter is required." + +This PR simply adds `extra_settings` to the list of possible parameters. + +Edit: I moved the default value of `extra_settings` to be set in the `get_extra_settings_dict_per_tenant` call. If `extra_settings` defaults to `{}` immediately, then the `v is None` check for `extra_settings` is never True. +
+
+ Created At 2023-11-17 10:13:37 +0000 UTC +
+
+
diff --git a/pull-requests/hyperledger/besu.md b/pull-requests/hyperledger/besu.md index 0c3349f3b..9cb8d40fa 100644 --- a/pull-requests/hyperledger/besu.md +++ b/pull-requests/hyperledger/besu.md @@ -10,6 +10,39 @@ permalink: /pull-requests/hyperledger/besu # besu [GitHub](https://github.com/hyperledger/besu){: .btn .mr-4 } +
+
+ + + + + + + + +
+ PR #6181 + + + just test + +
+ + + + + +## PR description + +## Fixed Issue(s) + + +
+
+ Created At 2023-11-17 12:17:05 +0000 UTC +
+
+
@@ -27,7 +60,8 @@ permalink: /pull-requests/hyperledger/besu
- in low peer count networks, be more lenient with timeout disconnections + in low peer count networks, be more lenient with timeout and useless response disconnects +Also reset all timeouts not just the specific messageCode
diff --git a/pull-requests/hyperledger/cacti.md b/pull-requests/hyperledger/cacti.md index 7ce47fde3..3f3c88f72 100644 --- a/pull-requests/hyperledger/cacti.md +++ b/pull-requests/hyperledger/cacti.md @@ -1851,50 +1851,3 @@ For rebasing and squashing, here's a [must read guide](https://github.com/servo/
-
- - - - - - - - - -
- PR #2870 - - - ci: add container scanning to default checks - -
- - - **Trivy** is a cutting-edge security tool designed to enhance the safety of containerized applications by conducting thorough vulnerability assessments. Specifically developed for scanning container images, ranging from low-severity issues to critical threats. It employs an intelligent rating system to categorize vulnerabilities based on their severity levels, ensuring that high to critical vulnerabilities are given special attention. Upon detecting vulnerabilities that fall within this elevated range, Trivy will throw an error. - -By integrating Trivy into our deployment pipeline, we can proactively mitigate security risks and enhance the resilience of our repository. - -Fixes hyperledger#1876 - -Depends On: hyperledger#2865 -Depends On: hyperledger#2864 -Depends On: hyperledger#2863 -Depends On: hyperledger#2862 - -**Pull Request Requirements** -- [x] Rebased onto `upstream/main` branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why. -- [x] Have git sign off at the end of commit message to avoid being marked red. You can add `-s` flag when using `git commit` command. You may refer to this [link](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) for more information. -- [x] Follow the Commit Linting specification. You may refer to this [link](https://www.conventionalcommits.org/en/v1.0.0-beta.4/#specification) for more information. - -**Character Limit** -- [x] Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters). -- [x] Commit Message per line must not exceed 80 characters (including spaces and special characters). - -**A Must Read for Beginners** -For rebasing and squashing, here's a [must read guide](https://github.com/servo/servo/wiki/Beginner's-guide-to-rebasing-and-squashing) for beginners. -
-
- Created At 2023-11-10 06:27:06 +0000 UTC -
-
- diff --git a/pull-requests/hyperledger/iroha-java.md b/pull-requests/hyperledger/iroha-java.md index 3e5ec28e3..fb35f1ba0 100644 --- a/pull-requests/hyperledger/iroha-java.md +++ b/pull-requests/hyperledger/iroha-java.md @@ -36,29 +36,3 @@ permalink: /pull-requests/hyperledger/iroha-java -
- - - - - - - - - -
- PR #387 - - - multi signature transaction - -
- - - -
-
- Created At 2023-11-10 09:16:39 +0000 UTC -
-
- diff --git a/pull-requests/hyperledger/solang.md b/pull-requests/hyperledger/solang.md index 9a899d8d5..6f3363646 100644 --- a/pull-requests/hyperledger/solang.md +++ b/pull-requests/hyperledger/solang.md @@ -114,30 +114,3 @@ This PR adds pragmas to the ast and we test it with a graphviz dot file. -
- - - - - - - - - -
- PR #1592 - - - Improve overloaded function call diagnostics - -
- - - Fixes: https://github.com/hyperledger/solang/issues/1534 -Fixes: https://github.com/hyperledger/solang/issues/707 -
-
- Created At 2023-11-10 09:15:26 +0000 UTC -
-
- diff --git a/trending/recent-prs.md b/trending/recent-prs.md index d8a25a7de..5b855eef5 100644 --- a/trending/recent-prs.md +++ b/trending/recent-prs.md @@ -1,13 +1,13 @@ +[6181](https://github.com/hyperledger/besu/pull/6181) just test + +[2612](https://github.com/hyperledger/aries-cloudagent-python/pull/2612) :bug: fix wallet_update when only `extra_settings` requested + [6179](https://github.com/hyperledger/besu/pull/6179) Stretch timeout when low peer count [2611](https://github.com/hyperledger/aries-cloudagent-python/pull/2611) feat: support resolving did:peer:1 received in did exchange [2609](https://github.com/hyperledger/aries-cloudagent-python/pull/2609) fix: more resilient checks in verify signed attachments -[1448](https://github.com/hyperledger/besu-docs/pull/1448) Bump got, @docusaurus/core, @docusaurus/plugin-client-redirects, @docusaurus/plugin-content-docs, @docusaurus/plugin-google-gtag, @docusaurus/plugin-google-tag-manager, @docusaurus/preset-classic, @docusaurus/theme-common, @easyops-cn/docusaurus-search-local and redocusaurus - -[1447](https://github.com/hyperledger/besu-docs/pull/1447) Bump trim, @docusaurus/core, @docusaurus/plugin-client-redirects, @docusaurus/plugin-content-docs, @docusaurus/plugin-google-gtag, @docusaurus/plugin-google-tag-manager, @docusaurus/preset-classic, @docusaurus/theme-common, @easyops-cn/docusaurus-search-local and redocusaurus - [See more >>>](https://start-here.hyperledger.org/pull-requests)