Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] SelectionHighlightColor Contrast Issue #132

Open
6 tasks done
GID0317 opened this issue Jan 23, 2025 · 2 comments
Open
6 tasks done

[Bug] SelectionHighlightColor Contrast Issue #132

GID0317 opened this issue Jan 23, 2025 · 2 comments
Labels
package: base Taking place in the iNKORE.UI.WPF.Modern project status: help-wanted Extra attention is needed

Comments

@GID0317
Copy link

GID0317 commented Jan 23, 2025

Describe the bug

SelectionHighlightColor has a wrong color contrast
Current:
Screenshot 2024-09-01 191429
image
WinUI:
image
image

Reproduction

Highlighting text

Suggested Solution

No response

Library Version

0.10.0

Operating System

Windows 11

Framework

.NET Core and .NET

Framework Version

8

Source of Package

NuGet.org

Additional Notes

No response

Validations

  • Check that there isn't already an issue that reports the same or similar problem.
  • Check that this is a bug in the library that should be fixed, not a feature, also this is not about the documentation. (Or please choose the right repo and template.)
  • This is one single problem, or a few problems with the same cause. (If you want to report multiple problems, please create one issue for every single problem.)
  • You've checked that this problem still exists in the latest version. (Keep in mind that we don't provide any support for old versions.)
  • You know that we can't guarantee that we will satisfy your request. This is not really our duty to do everything anyone asks for. Also, you will treat our staff, contributors, and other users with respect and kindness.
  • You're sure there's something wrong with the library itself, not how you're using it. (If you are having issues using it and need help, please go to discussion.)
@GID0317 GID0317 added the status: needs-triage Waiting to be triaged by our memebers label Jan 23, 2025
@NotYoojun
Copy link
Member

Before .NET 4.8, there's no way you can change the 'SELECTION TEXT FOREGROUND' of TextBoxes. Even though a new property called TextBoxBase.SelectionTextBrush came out in .NET Framework 4.8, it may encounter certain compatibility issues when working with .NET Framework 4.8-.

Image

This is really a tough decision to make. As a project that is referenced and used by a wide range of applications, we cannot just give up the support for older versions. However, I'm wondering if there's a way to add this feature only to the frameworks that support it, but I havn't found a way yet.

https://stackoverflow.com/questions/10850629/how-to-change-the-highlighted-texts-foreground-color-for-a-wpf-textbox

@NotYoojun NotYoojun added status: help-wanted Extra attention is needed and removed status: needs-triage Waiting to be triaged by our memebers labels Jan 23, 2025
@GID0317
Copy link
Author

GID0317 commented Jan 23, 2025

Thanks for the info on the TextBoxBase.SelectionTextBrush in .NET 4.8. Yeah, I get it's complicated. Maybe we can wait on this for now.

@NotYoojun NotYoojun added package: base Taking place in the iNKORE.UI.WPF.Modern project status: help-wanted Extra attention is needed and removed status: help-wanted Extra attention is needed labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: base Taking place in the iNKORE.UI.WPF.Modern project status: help-wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants