ICP 3.1.x installer ignores the user parameter if no repo was specified but the 3.2 installer takes what was passed

[damiengu]

See this thread out on ICP Public Slack Channel (request access here)
https://ibm-cloud-tech.slack.com/archives/C2HQFDAET/p1559926039028500

Hi I'm getting a strange docker authentication error while installing ICP 3.2
so the installer fails on TASK [icp-registry-image-push : Docker login to registry]
and this is the command it is sending docker login -u 'null' -p 'null' <cluster_lb_address>:8500
and getting and auth error from the registry as Error response from daemon: Get https://<cluster_lb_address>:8500/v2/: unauthorized: authentication required
also I have tried logging in to the registry manually using the admin credentials set in the config.yaml but I'm getting the same error

the issue it was not related to the installer but due to the terraform template for vmware here https://github.com/ibm-cloud-architecture/terraform-icp-vmware

the issue is in these lines
https://github.com/ibm-cloud-architecture/terraform-icp-vmware/blob/master/icp-deploy.tf#L70-L71

seems like ICP 3.1.x installer ignores the user parameter if no repo was specified but the 3.2 installer takes what was passed

i doubt it is fixable on terraform side without dropping the support for custom image repo the only way i got it to work was by deleting those lines

though it does feel like an issue with the installer why would it pick-up the username, and password if there was no repo specified ?