Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unsafe windows filenames properly #18

Open
Gum-Joe opened this issue Dec 4, 2024 · 0 comments
Open

Handle unsafe windows filenames properly #18

Gum-Joe opened this issue Dec 4, 2024 · 0 comments

Comments

@Gum-Joe
Copy link
Contributor

Gum-Joe commented Dec 4, 2024

Currently, when you do a mailmerge you get asked what fields from the data source should be used to generate the output filenames.

Unfortunately, sometimes those fields contain invalid characters (e.g. ":", can't include that in a filename in Windows). This can cause mailmerge generation to silently fail, and files end up created with nothing written to them (very easy to miss).

Solution: Make sure to normalise any fields used for filenames before using them as a filepath. Need to also make sure that any references made to those files in e.g. JSONSidecars or nunjucks metadata are also updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant