Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InterfaceSorption should enable recover #196

Open
simopier opened this issue Oct 19, 2024 · 0 comments
Open

InterfaceSorption should enable recover #196

simopier opened this issue Oct 19, 2024 · 0 comments

Comments

@simopier
Copy link
Collaborator

Reason

InterfaceSorption should enable recover, but it currently does not.

In /projects/TMAP8/test/tests/interfacekernels/InterfaceSorption/tests, transient tests are currently set with recover = false because residual_concentration is wrong.

Design

Enhance InterfaceSorption so that it supports recover.
Remove recover = false from /projects/TMAP8/test/tests/interfacekernels/InterfaceSorption/tests.

Impact

Enable recover with InterfaceSorption.
simopier added a commit that referenced this issue Oct 19, 2024
@simopier
Removing recover for transient tests, the residual_concentration is…
04cbb31 
… wrong

Creating a related issue (Ref. #196)
@simopier simopier mentioned this issue Oct 19, 2024
Merged
lin-yang-ly added a commit to lin-yang-ly/TMAP8 that referenced this issue Nov 1, 2024
@lin-yang-ly
Add "recover = false" in test case
add91f2 
Ref. idaholab#196
lin-yang-ly added a commit to lin-yang-ly/TMAP8 that referenced this issue Nov 5, 2024
@lin-yang-ly
Add "recover = false" in test case
fbefb82 
Ref. idaholab#196
lin-yang-ly added a commit to lin-yang-ly/TMAP8 that referenced this issue Dec 2, 2024
@lin-yang-ly
Add "recover = false" in test case
8d9b51a 
Ref. idaholab#196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simopier