Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Val-2c should perform consistently with 1 or 2 processors. #200

Open
simopier opened this issue Oct 25, 2024 · 0 comments
Open

Val-2c should perform consistently with 1 or 2 processors. #200

simopier opened this issue Oct 25, 2024 · 0 comments

Comments

@simopier
Copy link
Collaborator

simopier commented Oct 25, 2024

Reason

Validation case val-2c currently provides slightly different results when using 1 vs 2 processors, when it should provide the same results.

This issue arises later in the simulation close to steady state when concentrations are very small, which makes it acceptable for now, but this is an issue that should be addressed.

Currently, the tests are only run on 1 processor with max_parallel = 1 and this should be removed once this issue is fixed.

Design

  • Figure out the source of these differences
  • Fix it
  • remove max_parallel = 1 from val-2c/tests

Impact

More consistent parrallel capabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant